feat: add empty results test and improve devcontainer config#74
Merged
feat: add empty results test and improve devcontainer config#74
Conversation
When search returns 0 results, CypherEngine::from_json_auto fails to create a graph, causing the dataset to not be stored. This leads to "Dataset not found" errors when execute_cypher is called, forcing the AI agent to fall back to reading the JSON file directly. This commit fixes the issue by creating a minimal fallback dataset with a dummy node when the engine creation fails. Additionally: - Add logs/ and .skill-bench/ to .gitignore - Update mise.toml to run cargo install before skill-test - Increase timeout for patent-assignee-check/triggering test - Install skill-bench in devcontainer setup Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add functional-empty.toml test case for handling empty search results - Update Cargo.lock to version 0.2.0 - Format devcontainer.json with trailing commas - Add GitHub CLI config mount to devcontainer Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
mise run testmise run clippymise run fmtskill-bench run tests --skill patent-search🤖 Generated with Claude Code